Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ActionDialog, migrate some Dialog to DashboardModal #5044

Merged
merged 23 commits into from
Jul 17, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Jul 14, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Jul 14, 2024

🦋 Changeset detected

Latest commit: e64c08e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5044 July 14, 2024 11:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 15, 2024 10:11 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 15, 2024 10:25 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 15, 2024 11:31 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 15, 2024 12:00 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 15, 2024 12:23 Destroyed
@poulch poulch marked this pull request as ready for review July 15, 2024 14:17
@poulch poulch requested review from a team as code owners July 15, 2024 14:17
@github-actions github-actions bot temporarily deployed to pr-5044 July 15, 2024 14:22 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 16, 2024 08:38 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 16, 2024 11:49 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 16, 2024 20:16 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5044 July 17, 2024 08:11 Destroyed
krzysztofzuraw
krzysztofzuraw previously approved these changes Jul 17, 2024
Droniu
Droniu previously approved these changes Jul 17, 2024
src/components/ActionDialog/ActionDialog.tsx Outdated Show resolved Hide resolved
src/components/ActionDialog/types.ts Show resolved Hide resolved
src/components/ActionDialog/types.ts Outdated Show resolved Hide resolved
@poulch poulch merged commit dbe23dc into main Jul 17, 2024
15 checks passed
@poulch poulch deleted the merx-662-migrate-dialog-components branch July 17, 2024 14:47
poulch added a commit that referenced this pull request Jul 22, 2024
* Replace AppDialog

* Replace AppDeleteDialog

* Migrate dialogs part 1

* Migrate OrderChangeWarehouseDialog and StaffAddMemberDialog

* Migrate ActionDialog

* Improve imports

* ActionDialog size

* Small improvments

* Migrate ChannelPickerDialog autocomplete

* Fix pw selector

* Add chaneset

* Fix staff member submit

* Fix channel delete dialog

* update changeset

* Update font in ActionDialog

* CR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants